Design comparison
Solution retrospective
I have tried my best to make this responsive guys but Im struggling with that little horizontal slider that appears around 400px. if you could help me with it and other things that you might feel are bad in the code, i will be very thankful. Also, i have used jquery for images for different sizes so please reload the page once you start resizing and going near the mobile size.
I was also struggling with the top most background and keeping the big H1 inside the background during resizing. i somehow managed it but I know that's not the correct way so please if anyone could help me with it. it will be very kind of you.
Community feedback
- @ChamuMutezvaPosted over 3 years ago
Greetings SHUBHAM
So far so good. Here are what i think needs attention:
- look into using responsive images techniques , for example scrset or picture element . My observation is that your images are only loaded accordingly if i reload the page which is not happening when i shift from mobile view to desktop view. Using jquery in such cases is not the best choice.
- let your
nav-linksbe an unordered list and not h3 elements as well - an
h1element should be the first heading of your page - i see a repetition of some code as well like a navigation for mobile and another for desktop - that can be done with one and css can help to position the elements in the right position.
Happy coding
1@ProximamusicPosted over 3 years ago@ChamuMutezva Thank you so much for taking the time to provide such detailed feedback, I really appreciate it. this is what I needed. I will definitely work on these areas.
0 - @AlexC01Posted over 3 years ago
It looks great, but only one thing you forgot to edit the "SEE ALL" button
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord