Submitted over 2 years ago
Responsive log in page using HTML5, CSS Media query and little flexbox
@HenryAgu
Design comparison
SolutionDesign
Solution retrospective
Please feedbacks are highly appreciated.
Community feedback
- @denieldenPosted over 2 years ago
Hey Henry, congratulations on completing the challenge! You did a great job 😉
Let me give you some little tips for optimizing your code:
- to fix the background image size remove from body the
background-size: 1440px 700px
property - add
main
tag and wrap the card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - not use
<br>
to separate elements because it's for break the line of test, usemargin
property - remove all
margin
from.content
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding 😁
Marked as helpful0 - to fix the background image size remove from body the
- @Esesosa-maxPosted over 2 years ago
- ✅ Good Looking Design 3.94/5
- ✅ Responsive 3.9/5
- ✅ Good Attempt (See Way worse) 3/3
- ❌ HTML Not Properly structured 2.5/5
- ❌ Card is not properly Centerd
- ❌ unsuitable Font
Marked as helpful0@Esesosa-maxPosted over 2 years ago@HenryAgu , please you can mark it as helpful
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord