Design comparison
Solution retrospective
With this challenge I focused on getting the single-row to single-column transition without media queries. I linked the sources that helped me in the README.md. Let me know of any other ways to accomplish this without media queries, or if you have suggestions on improving what I currently have.
Any other feedback is also welcome.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, @GregLyons! π
Awesome work on this challenge! Your solution is responsive even without any media queries, amazing! π It's great that you've put some effort to explain the code that you've written! π
So, my recommendation is to try to fix all the accessibility issues that have been reported by Frontend Mentor and make the
:focus
and create the:focus-visible
styling different than the:hover
effect. The purpose of the:focus-visible
styling on interactive elements is to make the users that navigate the site using keyboard know where they are on the page.Keep up the great work!
Marked as helpful1@GregLyonsPosted over 2 years ago@vanzasetia Thank you!
The accessibility issues that Frontend Mentor reported on my end had to do with lacking an
<h1>
and a<main>
(which I've fixed now). I do try to be very aware of making:focus
visible, not just:hover
, and I believe I had that before (I tabbed through to check).However, I didn't know about
:focus-visible
before, and I think it'll be very handy for me going forward; it's been bothering me recently that if I put a:focus
style on a<button>
, the style will stay even after being clicked. It seems like:focus-visible
is the way to fix this, so thanks for that!0@vanzasetiaPosted over 2 years ago@GregLyons You're welcome! π
It's great that you've fixed all the reported issues! π Keep it up!
0 - @Kamasah-DicksonPosted over 2 years ago
your solution looks great and on smaller devices also. Texts are also readable. Another way you can achieved this also is by using CSS grid which has the minmax() Function to determine your minimum width and your maximum width. It sometimes need media queries depending on the design. Besides good job thereπ Happy codingπ
Marked as helpful1@GregLyonsPosted over 2 years ago@Kamasah-Dickson Thanks for the feedback. Using CSS Grid with
minmax()
for responsivity is also something I want to work on, so I'll keep that in mind for the future.0@Kamasah-DicksonPosted over 2 years ago@GregLyons am Glad to hear that, have a nice dayπ
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord