Submitted about 2 years ago
Responsive layout with vanilla CSS and HTML
@gustavoagoncalves
Design comparison
SolutionDesign
Solution retrospective
Hello guys!! Updating the code with the tips from @MelvinAguilar and @bccpadge Thanks guys!!
Another challenge that I enjoyed very much to complete and liked a lot the result. Fell free to point any improvements on my code.
Happy code everyone \m/
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @gustavoagoncalves 👋, good job on completing this challenge! 🎉
Here are other suggestions you might consider:
- Try to use semantic tags in your code. Click here for more information.:
With semantic tags:
<body> <main class="container"> <img /> <div> . . . </div> </main> <footer class="attribution"> . . . </footer> <body>
- The music icon is for decoration purposes only, so it could be hidden from screen readers by adding aria-hidden="true" and leaving its alt attribute empty:
<img class="note" src="./images/icon-music.svg" alt aria-hidden="true">
- Update these properties to place the background correctly:
background-color: hsl(225deg, 100%, 94%); background-repeat: no-repeat; background-size: contain; background-position: left top;
I hope those tips will help you.
Good job, and happy coding!
1 - Account deleted
Hello @gustavoagoncalves,
Your solution is almost done and here are some tips to improve your solution:
- To remove the repeating background on body element add this code:
body{ background-repeat: no-repeat; background-color: hsl(225, 100%, 94%); }
- Remove the color you applied to the card content and add
background-color: white;
- Remove the
background-color
on the cancel order button
I hope this helps you
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord