responsive layout with flexbox

Community feedback

• 

  P

  Jeff Guleserian•480

  @jguleserianPosted 5 months ago

  Good afternoon, Matte:

  Hey, thanks for letting me take a look at your solution for the QR Code Component. When I look at your code, it seems like everything should have worked out, but in practice, something happened when you posted to GitHub and hosted the site from there. Anyway, your basic coding looks good, both the HTML as well as the CSS, but there are a couple of things you will probably want to keep in mind as you move forward:

  1. GitHub gets kind of picky sometimes with your url references. So instead of starting your links to your images with a "./", try just the "/" and see if that helps. In the case of this project, both your favicon and you main QR image are failing to display. However, I imagine you are not experiencing a problem on your coding program because it is not as picky.
  2. Since your image is not displaying, what is showing up instead is the "description" within the image tag. the word "description" is showing up because that is the default. This is difficult both for those wondering what the picture was supposed to be about as well as for those who are visually impaired and have readers describing what is displayed.
  3. Another thing I find helpful when I review someone's work is being able to read their README.md file. Really, you should use the template and fill in the information and then rename the README-Template.md and overwrite the README.me. That way, you can explain your processes and vision as you carried out the project. I also find this type of self-expression helpful to the learning process. Also, writing to the Frontend mentor prompts when you do the actual submission is also helpful. I encourage you to take advantage of them.

  There are other things that could also be helpful for accessibility, but those steps can be left for the future. Meanwhile, I think you should be proud of your submission. You did a great job. The GitHub glitch just got in the way. Oh well, lesson learned.

  I hope you find these comments useful in some way. Again, good job and thank you for letting me take a peek of your work.

  Happy coding!

  Jeff

  0