responsive layout with CSS grid and flexbox

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @Elektrokat, great job on this project!

  Some suggestions to improve you code:

  1. For accessibility purposes, its better to use rem/em instead of px for your CSS property values.
  2. To make it easier to deal with CSS and have more control over your content, I suggest taking a look at CSS Resets.

  It makes it easier to make changes and will ensure that everything will look the same regardless of browser used and don’t have to worry that the browser will be using its own styling.

  One important thing about CSS Resets, is that there is no such thing as “one is better than the other.”

  CSS Resets are customizable for your preference.

  Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  Happy Coding!

  Marked as helpful

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @Elektrokat, Congratulations on completing this challenge!

  You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.Your solution is not responsive and I think this is due some width you've used somewhere instead of max-width that's not allowing the cards to behave as flexbo/flexible.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0