Design comparison
Solution retrospective
Should I give a class name to all my elements? I struggled a lot with making the content not go beyond the div, is there a way to make it say within the div at all times?
Community feedback
- @afaiz-spacePosted over 2 years ago
Hey @Isaaclkm, congratulation on completing the challenges. I noticed in the b-price class color is gray so removed the bottom padding and added verticle-align:6px; remove the flex from the box class.
Marked as helpful0 - @rockingrohit9639Posted over 2 years ago
Hey @Isaaclkm, It is good to have classes on all of your HTML elements, but there are some CSS Selectors which are very helpful while working and styling using CSS. To learn about different CSS Selectors you can go with the following link. CSS Selectors
Apart from it, some issues which I found are:-
- You should use semantic HTML tags like
main, section, footer, etc
in your HTML. - You should use
/
in image src not\
E.g. Use this
<img src=`images/perf1.jpg` alt=`perfume bottle`>
not this
<img src=`images\perf1.jpg` alt=`perfume bottle`>
Marked as helpful0 - You should use semantic HTML tags like
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord