Responsive Layout using Flexbox

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @mattbcowan 👋🏻

  I have a couple of suggestion to help you fix the accessibility and HTML issues.

  • First, <div class="attribution">...</div> should be <footer class="attribution">...</footer>. This will fix the accessibility issues.
  • Next, in this case instead of <section>, I suggest using regular <div> for a couple of reasons. First, when you use a <section> you have to have a heading, like h2-h6. Next, <section> is for bigger parts of a layout, such as, contact us about us, image gallery, etc. And this will fix the HTML issues. Just don't forget to generate a new repot once you fix the issues.
  • These two images should have, aria-hidden="true" because they are for decoration only.

  <img src="./images/bg-pattern-top.svg" aria-hidden="true">
  <img src="./images/bg-pattern-bottom.svg" aria-hidden="true">
  

  You can read more about aria-hidden here.

  I hope this was helpful 👨🏻‍💻 You did a great job for the second project, nicely done. Cheers 👾

  Marked as helpful

  1

  ---

  

  Matt Cowan•40

  @mattbcowanPosted about 3 years ago

  @kens-visuals appreciate it! I’ll be sure to update it with these changes. Thanks for the feedback!

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @mattbcowan no problem 😇

  0