Skip to content
Submitted about 4 years ago

Responsive layout using flex box and some customise components.

Kiriratanak Vorn•60
@KiriRatanak
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Fylo data storage component
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

For a component such as this I think I have used too much CSS and it looks a bit messy. I would appreciate some feedbacks on how to do better.

Community feedback

  • Roman Filenko•3,335
    @rfilenkoPosted about 4 years ago

    Hi Kiriratanak, seems like a preaty good work, a few notes thought:

    • try to be consistent with values (like margins, paddings, elements sizes, for example 2px, 14px, 15px, 9px, 81.5% and so on);
    • some css properties are inherited, so no need to overwrite them;
    • try to use more semantic tags;
    • would make icons as links.

    Keep practicing, Roman😉

    1
  • Kiriratanak Vorn•60
    @KiriRatanakPosted about 4 years ago

    Thank you @rfilenko for the comment. I'll keep that in mind.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord