Responsive layout using flex box

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 24 days ago

  Hi, well done.

  Here are some tips to improve your solution - I hope they are clear and helpful :)

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Headings should always be in order, so you never start with a <h3>. I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • Change .attribution to a <footer>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • To replicate the design, use the style guide to find the correct background-color.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height: 100% to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport. Remove align-content: center, and font-weight: 400, which is the default value.

  • Remove the margin on the card.

  • Remove all widths and heights in px. Setting fixed sizes can easily cause overflow, and should be avoided 95% of the time.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add height: auto, display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container. It also needs some rounded corners, so add border-radius: 10px.

  Marked as helpful

  1
• 

  Jorge•60

  @Broderpixelv1Posted 25 days ago

  Great start!, my recommendation is to apply semantic html; Despite being an apparently simple exercise, it is an opportunity to apply all the techniques and knowledge of html and css, with semantic html you will have a more functional structure identifying important sections, which will also allow you to organize and get the most out of flexbox in addition to being the start to scale to responsive sites. Very good, keep going!!

  Marked as helpful

  1