Responsive layout using flex and media queries
Design comparison
Solution retrospective
-My main problem was how i could get 2 columns for desktop version, i tried colum-count : 2 but it was hard to have a good responsive, so i used flex and it was so easy
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ✅
Your solution looks great!
I have a suggestion for improvement:
📌 Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful1@AngeATTPosted 5 months agoThanks u for your good advices as always ! I did change the tag and used main for SEO purposes@danielmrz-dev
0 - @tunaertenPosted 5 months ago
In terms of design, it is quite close to the original, but the fonts and colors are different from those specified. I don't think adding padding to the body in the CSS file is a good option; instead, I would add it to the necessary place (e.g., container or another element). I think I would use classes instead of IDs for larger projects because this way, I could use the same elements in multiple different places
Marked as helpful1@AngeATTPosted 5 months agoThanks for your reply, you are right i didnt use the right font color for the price i changed that@tunaerten
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord