@NehalSahu8055
Posted
Hello Coder 👋
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
Don't use
paddings or margins
for centering the card as it will notdynamically center
the card remove this and use either flex or grid for the same -
To
properly center the card
-
USING FLEXBOX on the parent element
body{
display: flex;
justify-content: center;
align-items: center;
min-height: 100vh;
...
}
-
You are
wrapping main and footer
inside adiv
its unnecessary to do this. -
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.
I hope you find this helpful.
Happy coding😄
Marked as helpful
@YeniUvwo
Posted
I found this very helpful. Thank you for that!
However, i just tried out your suggestion and this made my footer leave the bottom of the page.
@NehalSahu8055