Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive layout using CSS flexbox

Yeni 180

@YeniUvwo

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

_nehal💎 6,710

@NehalSahu8055

Posted

Hello Coder 👋

Congratulations on successfully completing the challenge! 🎉

Few suggestions regarding design.

  • Don't use paddings or margins for centering the card as it will not dynamically center the card remove this and use either flex or grid for the same

  • To properly center the card

  • USING FLEXBOX on the parent element

body{  
    display: flex;
    justify-content: center;
   align-items: center;
   min-height: 100vh;
   ...
}

  • You are wrapping main and footer inside a div its unnecessary to do this.

  • For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".

  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

I hope you find this helpful.

Happy coding😄

Marked as helpful

0

Yeni 180

@YeniUvwo

Posted

I found this very helpful. Thank you for that!

However, i just tried out your suggestion and this made my footer leave the bottom of the page.

@NehalSahu8055

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord