Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive layout using CSS Flexbox and media query css

@purna-dev

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


When I go for different Mobile devices it causes issues? Any error in my code please share your feedback?

Community feedback

T
Grace 29,310

@grace-snow

Posted

I recommend you read up about

  • the picture element
  • headings for semantic meaning
  • how to indicate extra information for screenreaders when using strike through text (they will hear both prices at the moment - you need to make it clear that one is the old price)
  • how to write good alt text on images and how to treat decorative images

Looking at this, perfume should not be a heading element, it should be a paragraph. If you want to give that ribbon text and heading some more affordance you can wrap them both in a hgroup element

Images don’t need to be wrapped in divs every time you use them. I suggest using a basic css reset at the start of your style sheet and that would set images to display block, which is what you are trying to do I think.

I hope these tips help

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord