Responsive Layout

Community feedback

• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hi ClariceAlmeida, I’m glad to hear that you imply what you learn in the previous code reviews, keep doing this approach, You will surely succeed.

  Some feedback on your solution

  • change should behave as it controls something, and for controlling I prefer to use button for navigating somewhere it is good to go with a
  • Avoid using width and height, you used width on your card, using hard code would cause some issues, I know in this solution your design is not very much affected form this, but in future projects, this habit falls you in cumbersome scenario. Try max-width instead
  • Your images should have alt attribute but for decorative images, you should leave alt as blank alt="" and use role=" presentation" or aria-hidden=" true" to make sure all screen readers ignore those images. In your case, the music icon and your hero image are decorative.
  • background-image is little bit off, trying to fix it by giving proper size and position. Position top and size contain would work in your cause. Hope it would help you

  Marked as helpful

  1

  ---

  

  Clarice Almeida•65

  @ClariceAlmeidaPosted about 3 years ago

  @muhammadshajjar Thank you, I changed the things you said and I'll remember that when i go to the next challenges.

  0