responsive landing using flex

Community feedback

• 

  James Dennis•220

  @emarketguy27Posted over 1 year ago

  Hi Elvis, just want to add a few words of encouragement. 3 months into learning front end dev and already producing results.

  I'm the same, around 3 months or so (i'm also 55 years old) and pivoting my work/life balance to include developing the knowledge and skills to become a dev. One thing you will realise is that most devs are more than willing to help.

  Keep up the great work..

  Marked as helpful

  1

  ---

  

  Elvis•220

  @ElvislexPosted over 1 year ago

  @emarketguy27 Thank you so much,

  1
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  congrats on completing the challenge successfully!

  There seems to be few issues, but to get started, you can add some min-width to the image in px or in rem, e.g. min-width: 300px to prevent it shrink down too much. This might make the image look distorted, so u can fix that by adding object-fit: cover; to the <img/>.

  Hope you find this feedback helpful!

  0

  ---

  

  Elvis•220

  @ElvislexPosted over 1 year ago

  @visualdenniss Thank you so much, i appreciate.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
      margin: 0;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .wrapper {
    margin: 7rem; 
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Elvis•220

  @ElvislexPosted over 1 year ago

  @0xAbdulKhalid Thank you so much, i really appreciate the help and corrections

  0