Submitted about 2 years ago

Responsive landing using Flex

Victor H P Sá• 130

@victorspoot

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Buchi• 160

@B-uchi

Posted about 2 years ago

Hello @victorspoot, your solution to this challenge is really nice. Here are few things i noticed in your code:

While styling your paragraph element, you didn't specify add .font-family and .font-weight
Also in your paragraph element, you utilized page breaks which I don't think was necessary since the text will automatically position itself based on your padding and alignment

Also try .box-shadow: 0px 3px 15px rgba(0,0,0,0.2) it should give you a better result.

Cheers and Happy coding

Marked as helpful

Victor H P Sá• 130

@victorspoot

Posted about 2 years ago

@B-uchi

Thank you for your feedback, i made the changes you suggested and it was much better.

Lucas 👾• 104,440

@correlucas

Posted about 2 years ago

👾Fala Victor, parabéns pelo desafio!

Acabei de olhar seu código aqui e tenho uma dica pra você, se você quiser deixar esse código o mais limpo possível, você pode excluir todas divs exceto aquela que segura os elementos e criar uma estrutura limpa.

<body>
<main>
<img>
<h1></h1>
<p></p>
</main>
</body>

Pro css você não precisa de nenhuma class, da pra selecionar tudo só com os seletores img, p e h1

Espero ter ajudado!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord