@mkboris
Posted
Hi Ashutosh-Neupane nice work, a good start on learning how to build responsive designs and flexible layouts is by using responsive units like rem
, em
, and %
for layout dimensions. Also, you shouldn't set fixed heights and widths on elements, the element's content and padding should determine it's size. Use max-width
or min-height
if you absolutely have to and the units should be defined with relative units like rem.
Other things to look at
- All content should be wrapped within landmarks. Wrap a
main
tag around card. and afooter
for the attribution. Also the footer should be the last element. More on semantic elements here - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
Hope this helps
Marked as helpful