Melvin Aguilar π§π»βπ»β’ 61,220
@MelvinAguilar
Posted
Hi @Haywayaheadshot π, good job completing this challenge, and welcome to the Frontend Mentor Community! π
I have some suggestions you might consider to improve your code:
- Use the
<main>
tag to wrap all the main content in your solution instead of using<section class="qr-generator">
.
- Use
<footer>
instead of<section class="attribution">
. The<footer>
element contains authorship information.
- Setting element width with percentages or VW will cause your component to behave weirdly on mobile devices and high-resolution desktops. You can set the
max-width
at 20rem instead ofwidth: 18vw
.
- To make alternative texts more useful, add descriptive text to the alt attribute of the QR image to explain what the QR image does, for example, "QR code to frontendmentor.io"
- Your solution should contain an
icon
.
<link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png" />
I hope those tips will help you! π
Good job, and happy coding! π
2
Abubakar Ummarβ’ 220
@Haywayaheadshot
Posted
@MelvinAguilar Thank you for the recommendations. I have implemented them
0