Responsive landing site

Community feedback

• Account deleted

  Hey @KIRUBASHANKAR26,

  Your solution looks great. It actually helped me solve some minor issues that I faced during my own run of this challenge. So thank you for that 😉

  Here are some feedback that could help improve your solution

  • Some of your p tags and div tag are nested inside a label tag. Which is causing the HTML issues to appear. That is because block elements aren't allowed to be nested inside inline elements. You can read more about it here
  • The background pattern in your solution is being resized and as a result, a media query was added to make the background cover the whole screen body{background-size: 100% 50%;}. Another approach (My approach ^^) to this would be to use the SVG component inside your index.html as an element and use the ::before / ::after selector to modify the look

  Other than that I think you did a fantastic job. Good luck on your next challenge 👊

  1

  ---

  

  kirubakk•245

  @KIRUBASHANKAR26Posted over 3 years ago

  @ktra99 Thank you so much :)

  1