Design comparison
Community feedback
- @StroudyPosted 2 months ago
Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…
- Add this to your
body
to center it, min-height: 100svh;
: Sets minimum height to full screen size for vertical centering.display: flex;
**: Enables flexbox for alignment.justify-content: center;
: Centers content vertically.flex-direction: column;
: Stacks items vertically.margin-inline: auto;
: Centers horizontally.
min-height: 100svh; display: flex; justify-content: center; flex-direction: column; margin-inline: auto;
-
You have some empty
alt=""
on your images, Having a clear and descriptivealt
text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines usealt
text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images, -
This should be in lowercase
<h1>PERFUME</h1>
and styled in CSS withtext-transform: uppercase;
, Keeping text lowercase in HTML improves accessibility and SEO. Usingtext-transform: uppercase;
in CSS separates content from style, ensuring screen readers interpret the text correctly. -
Using
max-width: 100%
ormin-width: 100%
is more responsive than justwidth: 100%
because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.
Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪
0@KachiTechbossPosted 2 months ago@Stroudy i have taken the correction
help me check it out
0 - Add this to your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord