Great work on completing this challenge. Your project closely resembles the given design. I did however find some issues with your code.
HTML
- You have used ids instead of class names for your styling. This is generally bad practice since ids have a higher specificity than classes. Use classes instead.
- You don't have to include "logo" in the alt text for the logo. It's also a good idea to wrap the logo in a link (
<a>) and use an alt text that indicates where the link goes to. For example "Meet - Home".
- "Built for modern use" is not an
<h2>, it's an ribbon text. Make it an paragraf and set "Smarter meetings, all in one place" as<h2>
CSS
- The page is not responsive on smaller devices. Under 400px (give or take) all of the main content is off-center. Can you see if you can figure out a way to solve this?
- Don't import your fonts in CSS, it's better to do it in HTML since it's better for performance.
- Use a modern CSS reset. Yours is quite odd... Josh Comeau and Andy Bell have good ones.
- Don't nest so much in your scss files. This causes high specificity and makes the code harder to work with.
Marked as helpful
1
Lena• 230
@lenanle333
Posted
This is extremely helpful feedback! Thank you so much @moadavou
1
