Skip to content
Submitted 7 months ago

Responsive landing page with Sass

Lena•230
@lenanle333
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Meet landing page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of getting my website to look very close to the original design file

What challenges did you encounter, and how did you overcome them?

A small challenge I encountered was figuring out how I wanted to style the hero images in desktop view. I have a wider monitor so the page looked a little off when the page was in full screen. I decided to not be too nit picky with it and keep it as it is.

What specific areas of your project would you like help with?

Any feedback helps!

Community feedback

  • Moa Davou•310
    @moadavouPosted 5 months ago

    Great work on completing this challenge. Your project closely resembles the given design. I did however find some issues with your code.

    HTML

    • You have used ids instead of class names for your styling. This is generally bad practice since ids have a higher specificity than classes. Use classes instead.
    • You don't have to include "logo" in the alt text for the logo. It's also a good idea to wrap the logo in a link (<a>) and use an alt text that indicates where the link goes to. For example "Meet - Home".
    • "Built for modern use" is not an <h2>, it's an ribbon text. Make it an paragraf and set "Smarter meetings, all in one place" as <h2>

    CSS

    • The page is not responsive on smaller devices. Under 400px (give or take) all of the main content is off-center. Can you see if you can figure out a way to solve this?
    • Don't import your fonts in CSS, it's better to do it in HTML since it's better for performance.
    • Use a modern CSS reset. Yours is quite odd... Josh Comeau and Andy Bell have good ones.
    • Don't nest so much in your scss files. This causes high specificity and makes the code harder to work with.
    Marked as helpful
    1
    Lena•230
    @lenanle333Posted 3 months ago

    This is extremely helpful feedback! Thank you so much @moadavou

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord