Responsive Landing Page with React, Styled Componenets, Grid, Flexbox

Community feedback

• 

  Mark Mitchell•1,820

  @markup-mitchellPosted about 3 years ago

  don't worry about speed, that happens naturally with practice.

  2

  ---

  

  Krishna Bansal•20

  @Krishna-bansallPosted about 3 years ago

  @markup-mitchell that's very true, I do have a far way to go. I hope it will get better with time

  0
• 

  Renaldy Prasetio•70

  @iceoficePosted about 3 years ago

  Hi Krishna Bansal,

  Welcome to Frontend Mentor! Well, I am also new here so let's up our skills together! I also finish this challenge in 2 days. I am not really familiar with React but here are my feedbacks,

  1. Add a default value for the timeframe, you can set 1 of them to be active so there won't be any 0 value there, {state === "" ? timeframe["weekly"]["current"] : timeframe[state]["current"]}

  2. Make it responsive! I am not really sure how to do it on React but it will be worth checking out.

  3. Remove any unnecessary console.log() that is used for debugging.

  Great job on finishing this challenge! Keep it up! I really like that animation. It makes me want to learn about animation 😅.

  1

  ---

  

  Krishna Bansal•20

  @Krishna-bansallPosted about 3 years ago

  @iceofice Hey Renaldy, Thanks for your Feedback, Its is fun to know that you also finished the challenge in 2 days, I saw your version as well its quite cool.

  I've taken note of your valuable feedback and will keep in mind too about not sending my console logs to deployments 😅

  As far the animations go they're quite simple 2 lines of code transition: all ease-in-out 0.2s; :hover { height: 100%; background-color: var(--desaturatedBlue); } that would suffice, Thanks for your encouraging words Lets Grow Together🚀

  1
• 

  sunil-sharma-999•405

  @sunil-sharma-999Posted about 3 years ago

  I really liked the hover animation!

  1

  ---

  

  Krishna Bansal•20

  @Krishna-bansallPosted about 3 years ago

  @sunil-sharma-999 thanks sunil

  0