Design comparison
SolutionDesign
Community feedback
- @Ging3rmintPosted over 2 years ago
Looks pretty good. A few ways to improve here.. for this sort of website, you would normally want to define a max-width to control the viewport. You can add max-width: 1440px and margin: 0 auto to your main container. Next, without looking into detail, i see you're using DOM listener for events.. that is not the recommended way. You should use react props and try to avoid DOM manipulation as much as possible (Only use Ref for variables and the DOM you want to add classes without changing the state/re-rendering a component).
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord