Design comparison
Solution retrospective
Hey there,
Do you have any suggestion to improve my css? How would you have handled the misaligned elements? Do you think it's a good solution to use margins or would you have used grid to do it?
Thanks in advanced,
Cheers
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
To better specify the main content of you site you will want to encase your entire component inside a Main Element.
-
The stars serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
To enhance the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful0@JeremyMenPosted about 2 years agoHi, @vcarames Thank you very much for your suggestions, I really appreciate it.
Have a great - coding - day!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord