Skip to content
Submitted 12 months ago

Responsive Landing Page with grid

Renukta-21•130
@Renukta-21
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...News homepage
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What did you find difficult while building the project? It'll be cool if you guys could tell me what's weird of my solution, or maybe could giveme suggestions for best practices, thanks :)

Community feedback

  • Ricky•460
    @rickyxyzPosted 12 months ago

    I'm also a beginner, so take this with a grain of salt 🧂.

    I think your HTML structure is odd.

    Take for example your 3 botCard cards, they have no container div to unify them. This could a problem when you have more than 3 cards, for example you would need to re-style the grid layout if there are 4 cards. I think it would be better if the botCard cards are contained in a div with grid or flex layout.

    Also you might want to look into semantic HTML5 guide.

    Cheers 🍻

    1
    Renukta-21•130
    @Renukta-21Posted 12 months ago

    @rickyxyz I think you're right, I'll take a look at the documentation and make a couple of changes. thanks btw! pd. Just started grid the day before yesterday, I'll try to do better

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord