Responsive landing page with form validation
Design comparison
Solution retrospective
Any better semantics, or way I positioned/displayed the image/s?
Community feedback
- @afrusselPosted over 3 years ago
I didn't know why there are 4 css files use for this project. More over use these 4 files after Google font. Other then that it's good
Marked as helpful1@NinjaInShadePosted over 3 years ago@afrussel There are 3 css files as far as I know. One for button/s, a main css file where the bulk of styling is, and a base for base styles, overwrites etc...
It's good practice not to chuck everything in one file.
0 - @palgrammingPosted over 3 years ago
You should remove the background color out of your
main
and put it on thebody
tag0@NinjaInShadePosted over 3 years ago@palgramming I wanted to make sure the bg was only used for the height of the content. If it was body, and you had a really big monitor, it'd look weird
0@palgrammingPosted over 3 years ago@NinjaInShade No adding a background color to your body tag is not going to make anything look weird but is going to get rid of the weird white gap at the bottom of your page
0@NinjaInShadePosted over 3 years ago@palgramming That's what I meant. I was being as pixel-perfect to the design as possible, and the design has a certain height which more or less mine is too. I guess if im not being perfect about it I should do this. Thanks, i'll be doing it :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord