Responsive Landing Page with CSS Grid using Organized SCSS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  Greetings Syafiqjos

  • here is what the instruction says To do this challenge, you need a basic understanding of HTML, CSS and JavaScript. You need some javascript for opening and closing the navigation
  • <a id="header-toggle" href="javascript:undefined" class="header__toggle"><i class="fas fa-bars"></i></a>, this should be a button(opening and closing the modal) - an anchor should be used to navigate to other sections of the page
  • <a href="#" style="--hover-color: var(--primary-color-2);" class="article__link">Learn more</a> , let your styling be in the css. Separation of concerns is important for cleaner and easy to debug code.

  Marked as helpful

  1

  ---

  

  Ahmad Syafiq Aqil Wafi•170

  @SyafiqjosPosted about 3 years ago

  @ChamuMutezva

  Hi Chamu, thank you for your feedback.

  Hmm.. I think I misread some of the instruction xD.

  You're right, at the first time I use anchor tag a so if the user press tab key on keyboard, the focus can be changing from one another. But href can't be empty so I use javascript:undefined. I tried to use button but suddenly it turns really ugly so I decided using anchor tag.

  Actually I want to use attr() but it doesn't work well so I tried to use css property like that --hover-color. But now you mention it, I just realized that styling in css would be better and clean.

  Thank you for the feedback! I'll learn to improve myself.

  0