Design comparison
Solution retrospective
Would love any kind of feedback. Especially if there's any better way to do this challenge. Thanks in advance :)
Community feedback
- @omarmohy98Posted almost 3 years ago
Hi@@Drougnov, wonderfully done! The code is remarkably responsive. Below is my feedback on potential improvements!
1.) your <a> tags not have discernible text that will make an accessibility issue, you can use aria-label="" to solve this problem, for example <a href="#"><i class="fab fa-facebook-f"></i></a> will be <a href="#" aria-label="Facebook Account"><i class="fab fa-facebook-f"></i></a>.
If you found my feedback helpful, please mark this comment as helpful. Wonderfully done. Happy coding!
Marked as helpful1@DrougnovPosted almost 3 years ago@omarmohy98 Thank you so much. I was worried about the accessibility issues cause I didn't know how to solve them. So thanks again. Going to fix them right now :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord