Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page with CSS Grid and EJS engine

@martinianol

Desktop design screenshot for the Time tracking dashboard coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! I used EJS but I believe React could be much better solution for this challenge. I hope you like it Mars

Community feedback

@solomondev01

Posted

This is absolutely beautiful and it's extremely mobile responsive. I saw that your first approach was mobile. Keep it up, mate!

Marked as helpful

0

@zineb-Bou

Posted

Hi there your design looks good and clean

Just some notes that may help you to improve your code even further

  • You are overusing <figure / > I think in this situation a simple button icon would be sufficient, <figure / > meant to be used for illustration, code, or diagrams where we need some description that accompanies the image.
  • Don't put your text inside a <div />, instead put it inside the corresponding HTML tag.
  • Avoid using px to set your units, px is not scalable, it is an absolute unit, em and rem is responsive, which will help the user to set their font preference the way they desire.
0

@martinianol

Posted

@zineb-Bou thanks for the feedback. I have changed the figure + used more semantic html. Changing all px to to em or rem will take a long time so it will be in the backlog for the time being until next sprint :-)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord