Responsive landing page with CSS Grid and EJS engine

Community feedback

• 

  DevMiller__•70

  @Begotten-TravelerPosted about 3 years ago

  This is absolutely beautiful and it's extremely mobile responsive. I saw that your first approach was mobile. Keep it up, mate!

  Marked as helpful

  0
• 

  Zineb Boutaa•750

  @zineb-BouPosted about 3 years ago

  Hi there your design looks good and clean

  Just some notes that may help you to improve your code even further

  • You are overusing <figure / > I think in this situation a simple button icon would be sufficient, <figure / > meant to be used for illustration, code, or diagrams where we need some description that accompanies the image.
  • Don't put your text inside a <div />, instead put it inside the corresponding HTML tag.
  • Avoid using px to set your units, px is not scalable, it is an absolute unit, em and rem is responsive, which will help the user to set their font preference the way they desire.

  0

  ---

  

  Mars - Martiniano Leguizamon•115

  @martinianolPosted about 3 years ago

  @zineb-Bou thanks for the feedback. I have changed the figure + used more semantic html. Changing all px to to em or rem will take a long time so it will be in the backlog for the time being until next sprint :-)

  0