Design comparison
SolutionDesign
Solution retrospective
Hi,
this is my second project i took your last advice and tried to implement them.
I struggled with the background and the layout but happy with the final result
I would like to read your reviews
thanks
Community feedback
- @ChamuMutezvaPosted almost 3 years ago
Greetings Ori. Several issues have been mentioned in the automated feedback which may include some of the following:
- the sizes for the images in your html should be unitless. eg `<img width="266" height="400" src="/images/svg/bg-pattern-1.svg" alt="" class="tabletDesktopImage" />
- alt values should be descriptive for the benefit of assistive technology users. The value should carry the message that is being sent through the message.
- the first heading element of a site should be an h1
- the ios and android buttons , i think they should be anchor elements . It looks as if they are links pointing to the download sites
- the social images are links to social accounts, hence they should have been nested in anchor elements.
- the body represents the viewport and adjusting the height and width should be avoided, rather you should have a div container that is the immediate child of the body that you can apply sizes to.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord