Responsive Landing Page Using SASS, Grid and Flexbox

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted about 3 years ago

  1- On larger screen sizes(around 1500px) the header is no longer centered which makes the layout inconsistent, to mitigate this you should create some sort of container helper class which is what I use in all of my projcets.

  2- Th links in the footer should not be static text bu rather actual link, just wrap them inside a element and add the appropriate styles and regarding it's alignment you can use self-align property(it shouldn't be ceter vertically).

  3- The logo looks fine but I personally would probably resize it a litle bit and dont change it's layout for mobile.

  4- 7-1 architecture is quite good and has many adventages,it helps you modularize you style and use predefined function to mention a few. Some that would make imports easier would be having a _index.scss partial in every directory wich forwards the content of each directory and than in you main file you just import the whole directory for instance @use "../abstracts" as a; Spend some time reading about the new way of importing and exporting stuff in sass with @use and @forward.

  0