Responsive landing page using queries.

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hey, Pompey-hub! 👋

  Nice work on this challenge! 🙌

  A couple of things I'd like to suggest are,

  • Using padding to add some space between the card component and the edges of the screen (especially when the width of the screen decreases).
  • Using button elements for the buttons at the bottom of the card component (not div elements, which aren't interactive or very meaningful).
  • Rather than adding to margin to each child element inside a container element to add space between the container element and the children inside it, add some padding to the container element and use margin to add space between its children (or better yet, use flexbox instead). This is better because you only have to set the value for the space around the content of a container in one place, which helps improve consistency and avoid mistakes. 😉

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0