Design comparison
Solution retrospective
I think the most difficult part building the project is building the css especially arranging the inside the container and making it responsive. I'm not sure if did well in queries part for mobile version. Any suggestions?
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <span class="bold"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
For a responsive content which wont require a media query for this challenge replace the width in .container with max-width. Reduce the width of .container for it to be equivalent to the design.
max-width: 320px/20rem
Give p and h1 the same font-size of 0.9375rem which is 15px. Give .container a padding value for all the sides instead of a padding-bottom value.
To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .container on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .container on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
There is no need to give h1 and p font-weight values and give h1 and p margin-left and margin-right values.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord