Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="main-container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .main-container on the page using flexbox, replace the height in the body with min-height: 100vh.
Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.
For a responsive content which wont require a media query for this challenge, replace the width in .main-container with max-width, give it a fixed value instead of vw value and increase the padding value.
max-width:320px padding:16px
Give the img a max-width of 100% instead of a width and height value. Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So fix it by replacing the
<div class="main-container">
with semantic element<main>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord