Responsive landing page using media querry

Community feedback

• 

  Leonard•1,025

  @leoikeh99Posted over 1 year ago

  Good solution, i have a couple of feedbacks:

  • For the button it better to set only the padding for the top and bottom and then set a width of 100%, i.e.: padding:1rem 0;, this will help with overall responsiveness
  • For the right side where you have the h3 there are couple of ways to make sure the img and the plain text are properly vertically aligned, you could set the h3 to display: flex and align-items: center, this will help with the alignment

  Marked as helpful

  0

  ---

  

  Tochukwu•90

  @kelvtmoneyPosted over 1 year ago

  @leoikeh99 thanks a lot for the feedback, was really helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by wrapping the <div class="content"> element inside the semantic element <main> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  CSS 🎨:

  • Use min-height: 100vh instead of min-height: 700px;, to properly center the component both horizontally and vertically

  ---

  • Setting the height to 700px may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation

  ---

  • min-height says that the minimum height is some value but that the element can continue to grow past that defined height if needed (like the content inside makes it taller or whatever).

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Tochukwu•90

  @kelvtmoneyPosted over 1 year ago

  @0xAbdulKhalid thanks a lot for the feedback, it was really helpful and encouraging. I will improve on the code

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @kelvtmoney Glad you found it helpful ! 🤠

  Marked as helpful

  0