Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page using media queries

jeevan-v-jijoā€¢ 10

@jeevan-v-jijo

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Things that I am proud of

-Learnt about media queries

-Learnt about center a div, vertically and horizontally in a screen

-position and display properties

What challenges did you encounter, and how did you overcome them?

Challenges encountered

-positioning

I overcame it by researching online resources

What specific areas of your project would you like help with?

I want to know if my positioning and spacing methods are appropriate or not? If not how can I improve? what are the best practices.

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello there!

Congrats on completing the challenge! āœ…

Your project looks great!

I have a suggestion about your code that might interest you:

šŸ“Œ You can use the <picture> tag when you have different versions of the same image.

Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

Example:

<picture>
    <source media="(min-width: 768px)" srcset="{desktop image path here}">
    <img src="{mobile image path here}" alt="{alternative text here}">
</picture>

I hope this helps!

Other than that, excellent work!

1
Shoaib Shujaā€¢ 560

@ShoaibShuja

Posted

First of all for spaces you can use 1rem instead of like 1px which would apply more space at once because 1rem is equal to 16px and this way you can examine different spaces quickly. Also dont forget that you can use an extra one digit decimal with rem like .5rem which is basically 8px to match designs more effeciently.

Also if you want to put your elements perfectly centered inside the body element instead of using position use flexbox in body element. This way you don't have to worry about positioning when using media queries and applying for smaller or bigger devices. This tip is optional but I believe is a better approach. To test this remove the position, top, left and transform from your .main-dev and the media queries and copy following code to your CSS file:

body {
    width: 100%;
    min-width: 100vh;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
}

I wish you good luck my friend.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord