Responsive landing page using HTML, SCSS and BEM class naming conventi

Community feedback

• 

  Folarin Akinloye•1,240

  @folathecoderPosted over 3 years ago

  Hi, Akshay Meshram!

  Your solution looks clean on most devices except very large screens (like 5000px width). It is important to make a webpage appear perfect on larger screens also, because monitors of those sizes are becoming very common.

  You can assess this by using a browser inspector to check for responsiveness on huge screens.

  Solution: You can wrap each section and give them an appropriate max-width, instead of setting the width to 100% (this will take the width of the whole screen)!

  I hope this helps!

  Happy coding!

  1

  ---

  

  Akshay Meshram•390

  @akshay63Posted over 3 years ago

  @folathecoder Thanks for your feedback! I'll definitely try to make my sites more responsive for all types of devices in my upcoming solutions. Happy learning!👍😎

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, Akshay Meshram! 👋

  Nice work on this challenge! 🙌

  One or two things I suggest are,

  • Turning the social media icons in the footer of the page into links by wrapping them in an anchor tag.
  • Perhaps considering using min-width (instead of max-width) in your media queries for your next project, since min-width works well with a mobile-first and occasionally loads fewer styles for devices with small screens (which might make your site load slightly faster). 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Akshay Meshram•390

  @akshay63Posted over 3 years ago

  @ApplePieGiraffe Thanks for your feedback, APG! I'll try to use min-width for Mobile-first responsive design in my upcoming projects.

  0