Design comparison
Solution retrospective
Your feedback is very important to me. It helps me improve my coding style. Thank you!
Community feedback
- @K01wfdPosted about 1 year ago
Hi @reemalnaji, my tips for your solution:
1- In your HTML file try to use semantic HTML elements so it would be more accessible for screen readers, for example: wrapp all your content inside main element.
2- When using svg in HTML, you specify the src link to your svg file directly in img element without using the svg itself in your code.
3- Use global selector on top of your css file to reset some default styling instead of using it on body.
4- Consider using CSS custome properties to define Colors, Typography, Sizes.
5- Try not to use explicit width or height on elements, always stick with the default witch is (auto), or you set the maximum or minimum threshold (max-width, min-width).
0@reemalnajiPosted about 1 year ago@Korg01wfd Thank you so much. I'll apply your tips to my next project. 😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord