Design comparison
SolutionDesign
Solution retrospective
Most difficult was definitely the triangle for the mobile menu and header - it went through a lot of modifications but the end product works best in my opinion. I wanted to just practice the basics so its just pure HTML, CSS and JS solution.
Any ideas on how to improve this?
Community feedback
- @0xabdulkhaliqPosted 9 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a recommendation regarding your code that I believe will be of great interest to you.
ANCHOR ELEMENT 🔴:
- The Social
<a>
elements lacksaria-label
attribute which is way more important for social links in an<a>
tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.
- When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an
aria-label
attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.
- By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.
- Example:
<a href="#" aria-label="Facebook profile of Sunnyside"> <svg> ...... </svg> </a>
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Gosia-RasPosted 9 months ago@0xabdulkhalid Thanks a lot Abdul, I corrected the anchor tags and added the aria-label to it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord