Responsive landing page using HTML and CSS flex box

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Ebunski 👋🏻

  I'm so happy that you're so happy for your first project, but unfortunately, the link you put doesn't work. I'm not sure if you're still working on it or what, however, try to fix it, so the community can give some feedback.

  I hope this was helpful 👨🏻‍💻 Cheers 👾

  Marked as helpful

  0

  ---

  

  Ebunski•120

  @EbunskiPosted about 3 years ago

  @kens-visuals Thank you..I'll fix that

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @Ebunski you're welcome 😇

  0

  

  Ebunski•120

  @EbunskiPosted about 3 years ago

  @kens-visuals Check it out now

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Ebunski 👋🏻

  It works now, so let me give you a couple of suggestions on how to fix the accessibility issues and some other things.

  • In your markup, <div class="container">...</div> should be <main class="container">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • For the music icon, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here. Like this:

  <img src="images/icon-music.svg" alt="" aria-hidden="true”>
  

  • Also, I suggest adding transition: all 0.2s; to the button and the links, this will make :hover smoother.
  • Lastly, add min-height: 100vh to body, so background-color and background-image cover the whole space.

  I hope this was helpful 👨🏻‍💻 other than that, you did a great, keep it up. Cheers 👾

  Marked as helpful

  0

  

  Ebunski•120

  @EbunskiPosted about 3 years ago

  @kens-visuals Always happy to hear your review. This accessibility thing is still new to me. I didn't quite understand what you said about generating a new repot. I'm new to frontend mentor. Can we meet up on slack?

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @Ebunski I don't have Slack sorry, but I'm always here, and whenever I see a new comment I try to respond as soon as possible. So in order to generate a new report, click on View Report and then in the top left corner you'll see Generate New Report, click on it to clear the fixed issues.

  0