Responsive landing page using html and css

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  Hey Mansoor, nice to see your submission for this challenge, you've done a good job! APG has given you some great tips already. I'd definitely recommend trying to resolve the accessibility errors. Building accessible web pages is a key part of being a front-end developer, so these projects are a great place to practice this.

  The overall layout of your elements looks good, but I'd recommend one more round of refinements to try and get the sizings and spacings matching up to the design. Training your eye for detail will be well worth the effort.

  When an img doesn't add any extra context to the content, you can make screen readers skip them by adding alt="". I'd say that this would be useful for the illustration, as it doesn't really add much to the written content. Also, your alt text for the logo uses a hyphen at the moment. For alt text, write is as you would a normal line of text. For the logo, simply having the word "Huddle" inside would do the trick as it's a company logo.

  I hope these pointers help. Keep up the great work and Happy New Year! 🙌

  2

  ---

  

  Mansoor Roeen•420

  @mansoor-roeen-glitchPosted almost 4 years ago

  @mattstuddert Hello Matt, thanks for the feedback and suggestions I am gonna fix it soon ! happy new year !! 🎉🎉🎊

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Mansoor Roeen! 👋

  Good work on this challenge! 👏 Your solution looks pretty good! 👍

  I suggest,

  • Decreasing the size of the paragraph text and increasing the font-weight of the heading to add some contrast between the two (as in the original design).
  • You can get rid of those errors on your solution report by adding a <title> tag to your inline SVGs (as in <svg><title>Visit our Facebook page</title>... </svg> or something). 😉

  Keep coding (and happy coding, too)! 😁

  And have a happy new year! 🎉

  1

  ---

  

  Mansoor Roeen•420

  @mansoor-roeen-glitchPosted almost 4 years ago

  @ApplePieGiraffe Hey applePie, thank you for your great feedback and suggestions I would definitely fix it all and happy new year ~!

  0