Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page using HTML and CSS.

@theJRodrigues

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Jeroen Leijnseβ€’ 1,420

@jrleijnse

Posted

Hey there! Great job completing your first challenge! 🎊

I have some suggestions for your code that might interest you.

HTML πŸ“„:

  • Instead of using the <div> tag for your containers, try using some semantic HTML to provide more meaning to it, for better SEO. For example, instead of using <div> you could use the <main> or <section> tag. For the element with the classname attribution you could use the <footer> tag.
  • If an <img> like in this case the QR-code, leads to a website or links to someplace else, try to provide a more descriptive text of that in your ALT text, for example: QR code that leads to frontendmentor.io

CSS 🎨:

  • To make your project more responsive and adaptable (in this case as well: especially when you start building bigger and bigger projects), I would suggest to use rem instead of px. This basically means that all sizing will be calculated in relation to the root element (rem). To set the standard font-size for the root element, you can provide a font-size inside the HTML element inside your CSS. For example: html {font-size: 15px;}.

For more information on this topic, you can read the following article: PX or REM in CSS? πŸ“˜

  • To make your solution responsive for different devices and screen widths, you can create a media query inside your CSS file and set the breaking point (i.e. the moment your media query gets triggered based on the width of the viewport). For example: @media (max-width: 375px) { ***Place your CSS code here, just like you would in a regular CSS file***}.

For more information on this topic, you can read the following article: Media queries πŸ“˜

I hope you find my suggestions useful, and above all: the solution you provided is very good!

Keep it up and happy coding! πŸ˜ƒ

Marked as helpful

0

@theJRodrigues

Posted

@jrleijnse

Wow, thanks so much for the feedback on my code.

Thanks also for the tips when using "REM" and "Media Query".

I'm doing a new challenge and I'm using these tags and media queries, a little complicated, but researching about.

Sorry for any English mistakes, I'm using the translator, because I only know the basics.

I expect more feedback on my next challenge!

Thanks ;-)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord