Responsive landing page using Grid

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  I forgot, the Frontend Mentor logo is not displayed because url is wrong, you can correct it like this: src="./icons/favicon-32x32.png or src="icons/favicon-32x32.png

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Foxynoxy, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • remove all margin from .container class because with grid they are superfluous
  • add min-heigth: 100vh and place-content: center; to .container class because grid aligns to the size of the parent container
  • try to add a little transition on the element with hover effect

  In the end, Tip of graphic design: With font-family:" Big Shoulders Display ", cursive the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading) ... for the designer it's a really awful font!

  • I would rather replace it with a font-family:" Big Shoulders Display ", sans-serif much more similar to the primary font.

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0