responsive landing page using grid

Community feedback

• 

  Stephane Baroux•165

  @steppan26Posted over 3 years ago

  Hi @tabetommy, it loos good from the preview window but clearly the sizing and spacing is a bit off as your image is shorter than the design. I am new to web dev, so I am not in a place to realistically critique your code, but I would for sure work on the things brought up in the report (Accessibility issues and HTML issues), you'll find that adding an 'alt' tag to all your images will resolve a large portion of those too.

  As for the colour scheme, I have noticed that sometimes the ones provided are a little off from the design, but there's a bunch of sites out there which will let you grab the colour from an image (try something like https://coolors.co) so you can get it right.

  Keep going and good luck with the future.

  0

  ---

  

  Tommy Tabe•150

  @tabetommyPosted over 3 years ago

  @steppan26 thanks for your comments man. I will definately edit my code. About the isuue with hte colors. I didn#t quite understand what you meant please can you clearify. I'll appreciate

  0

  

  Stephane Baroux•165

  @steppan26Posted over 3 years ago

  @tabetommy no problem, I am learning too and community feedback really is valuable. [feel free to upvote the comment ;-) ]

  That link is a website which allows you to create colour palettes, and one of those options is to create a palette from an image (you should see a little camera icon). Once you have selected your image it will load into a window which will allow you to use a colour picker to select colours from your image to generate your own custom set of colours. Once your palette has been created you will have a number of different options for each (such as viewing a selection of different shades from the same colour). The number at the bottom will usually be the hash value (you just need to add # in front it the numbers in your code for it to represent a colour). If you prefer to work with other types of colour formats (such as RBG or HSL) you can click on the number and there you will be able to select the one which suits your needs.

  Hope it was helpful

  0