Design comparison
SolutionDesign
Community feedback
- @ChamuMutezvaPosted almost 3 years ago
Hi. Here are a few of my observations
alt values
- image alt values can be empty for decorative images , other than that the alt value should be descriptive to assist assistive technology users get the meaning that is being put across. Values like logo, picture , image are redundant as they are automatically announced by screen readers.
- while the image is that of a hamburger icon it does not help assistive tech users as the message that should be put across relates to a button that should be opening and closing the menu. This is in reference to the hamburger icon in the header
semantic html
- using semantic html has benefits to your users. For interactive purposes , elements like a button are appropriate to use . An image can not be used as a button for the benefits of users - among other things it is not keyboard focused. A common method used is to wrap the image with a button.
- the navigation lists has to be links
general
- the hamburger menu is not working .
Marked as helpful1@halamhPosted almost 3 years agoHi @ChamuMutezva ! Thank you so much for your observations!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord