@i-prkr
Posted
This is a great solution!! I enjoyed looking at it and it looks very good.
I am not familiar with Vue projects yet so I am not sure what to suggest, but it appears as though <header-content> images are not changing for smaller devices and is still showing the 'left' and 'right' images meant for desktop. I can see in Vue.app where the isDesktop() function is being used to change the image but it might not be working correctly? I've tried it on chrome and firefox.
Also with regards to using @use and @forward for sass, I found a video on youtube really helpful, by Kevin Powell. https://www.youtube.com/watch?v=CR-a8upNjJ0
Great solution!
Marked as helpful
@JamesLaviron
Posted
@i-prkr Thanks a lot for your comment :) Very helpful, I'll look at the video. For Vue device detection, it seems like it's called only one time so window resize won't work using this technique. But I assume ppl won't resize it after page has been called
@JamesLaviron
Posted
@i-prkr The video you sent me is very clear!! Thanks a lot mate :)
@i-prkr
Posted
@JamesLaviron Ah I understand, that makes sense.
Great I'm happy that it was helpful!! :)
