Design comparison
SolutionDesign
Solution retrospective
It was an amazing experience.Thankyou
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @shantanu-crypto 👋🏻
I have some suggestions on how to fix the accessibility issues and some other minor things.
- First,
<div class="main_box">...</div>
should be<main class="main_box">...</main>
. This will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues. - Next, I'd suggest trying to implement
:hover
state on button and links, and adding shadows to the card. Perhaps, making it a bit bigger would also be a good idea. - Also, the music icon, should have
aria-hidden="true”
, because it's for decoration. You can read more about aria-hidden here.
I hope this was helpful 👨🏻💻 good progress for the first project, well done. Cheers 👾
1 - First,
- @rohitdubey1352Posted about 3 years ago
This is awesome! Your design skill is very good, keep it man.
0@shantanu-cryptoPosted about 3 years ago@rohitdubey1352 Thankyou sir you always motivated me .Thankyou So much
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord