Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page using Flexbox

@lifeaddikt

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone, hope you are good :)

I have few questions on this challenge !

  1. First of all, how can i change the color of a SVG image, like in the footer, the logo should be green. I know how to change with filter but i need a specific color here not just white or black or greenish.

  2. What do you think about my markup for testimonial items, i insert an image inside a blockquote, should i use figure tag here ?

  3. What HTML do you use for social media links ? do you use nav tag ?

  4. Here i use background image to set up the different images, is that good ? or should i use <img> tag ? I used it bc its visual image there is no link with the content.

  5. What ALT do you write for 'arrow down' or link to social medias ?

Thank you ! Have a nice day

Community feedback

@JimaLoko

Posted

on this website you can put the color you want in hex which will generate the filter automatically. congratulations on the solution

https://angel-rs.github.io/css-color-filter-generator/

Marked as helpful

1

@lifeaddikt

Posted

@JimaLoko !!! So good thank you :)

1
PhoenixDev22 16,950

@PhoenixDev22

Posted

Hi Victor Paumier,

Congratulation on completing this challenge. Excellent work! I have some suggestions regarding your solution if you don’t mind:

  • Well done with adding thearia-expandedand aria-controlson the toggle.
  • As the button has no discernible name, put an aria-label on your trigger to describe its purpose. For example, you can have: aria-label='Mobile Navigation Trigger' or 'Open Menu.’
  • You should use aria-controls attribute on the toggle element, it should reference the id value of the <ul> element.
  • Use the<nav > landmark to wrap the footer navigation with aria-label=”secondary “ or aria-label=”footer”. A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label. Thenav element in the header could use an aria-label="primary" or aria-label=”main” attribute on it. The reason for this is that, You should add the aria-label for a nav element if you are using the nav more than once on the pag..you can read more in MDN
  • You may use semantic an unordered list <ul>to wrap the social links class="footer__social-medias", you put your links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.
  • The links wrapping the social images must have aria-label or sr-only text indicate where the link will take the user. Then add aria-hidden=”true” to the images that make them be ignored by screen readers to avoid redundancy and repetition.

Overall, Your solution is good. Hopefully this feedback helps.

Marked as helpful

1

@lifeaddikt

Posted

@PhoenixDev22 wow thank you for this very complete answer !

It is true that I have only superficially explored the aria attributes. I will have a deeper look in it and use all your remarks !

Thank's :)

0
PhoenixDev22 16,950

@PhoenixDev22

Posted

@lifeaddikt Glad to help. Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord