Boris• 2,870
@mkboris
Posted
Nice work adriantech-beep, you are right It's not good practice to wrap every element in div because divs aren't semantic. Here's how you can make it better
- All content should be wrapped within landmarks. Wrap a
maintag around .container. - This isn't a
form, a form would typically include elements likeinput,textarea, orbuttonfor user input. You could use adivinstead ofform. - For the .navLinks use unordered list for better semantics and accessibility
ulinstead of divs and wrap eachainli. - It's best practice linking Google fonts directly in the HTML
headsection rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Media queries, font-size should be defined in
remnot px
Hope this helps
Marked as helpful
0
P
adriantech-beep• 160
@adriantech-beep
Posted
@mkboris Thank you so much for this. It's a great advice for me as a newbie. I will apply this tips on my next challenges and also try to redo my solution.
1
