Responsive landing page using flexbox

Community feedback

• 

  P

  Levi•230

  @law973Posted about 2 months ago

  Hey there! I like the way your solution turned out visually.

  Regarding the usage of rem units, there's a great article called "The Surprising Truth About Pixels and Accessibility" that I found helpful: https://www.joshwcomeau.com/css/surprising-truth-about-pixels-and-accessibility/

  One other thing: the deep blue color of the links in the attribution section makes them a little hard to read when they have a dark background behind them; choosing the right colors to create enough contrast between pieces of text and their backgrounds is important. There's a tool called a Contrast Checker that's really handy in this regard: https://webaim.org/resources/contrastchecker/

  Hope this helps!

  0
• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

   <div class="card-social-link">
       <a href="https://github.com/JuanBachurDEV" target="_blank"><p>GitHub</p></a>
   </div>
  

  • The code isn't semantically correct because a block-level <p> tag is inside an inline <a> tag. Instead, place text directly within the <a> tag or use a <span> for styling, ensuring proper HTML semantics and accessibility.

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  0